Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme does not work as is worked before 0.7 #142

Closed
bortevik opened this issue Apr 25, 2018 · 3 comments · Fixed by #146
Closed

Theme does not work as is worked before 0.7 #142

bortevik opened this issue Apr 25, 2018 · 3 comments · Fixed by #146
Assignees
@nlfurniss
Labels
bug Regression

Comments

@bortevik
Copy link

Replacing jquery extend(true, ...) to ember assign in buildOptions broke themes in our app. I think this the case for others as well.
@nlfurniss nlfurniss self-assigned this Apr 25, 2018
@nlfurniss
Copy link
Collaborator

@bortevik Thanks for reporting, will put a fix out

@nlfurniss
Copy link
Collaborator

@bortevik can you provide a failing test case i can add to this repo to prevent further regressions?

nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 15, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
ce6052b
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 15, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
43394c1
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 15, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
b1fe33d
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 15, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
95ad7ec
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 15, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
69d2c3e
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 15, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
8f8b7f8
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 15, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
5151e25
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 15, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
a5fd87c
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 15, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
af6a17e
@nlfurniss nlfurniss mentioned this issue Aug 15, 2018
Merged
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 15, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
d87af4d
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 16, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
cf72b5b
nlfurniss added a commit to nlfurniss/ember-highcharts that referenced this issue Aug 16, 2018
@nlfurniss
Fix issue that broke themes ahmadsoe#142
633bb3d
nlfurniss added a commit that referenced this issue Aug 16, 2018
@nlfurniss
Merge pull request #146 from nlfurniss/fix-options-deep-merge
773d144 
Fix issue that broke themes #142
@nlfurniss
Copy link
Collaborator

@bortevik this is fixed in 1.0.1 - please check it out and sorry for the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlfurniss nlfurniss

Labels
bug Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue that broke themes #142 nlfurniss/ember-highcharts
2 participants
@nlfurniss @bortevik