Correctly load n_dims for openai_whisper model #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariqislam
approved these changes
Dec 13, 2024
|
@ahmetoner Perhaps this PR is related to the bug I opened for OpenAI Whisper not translating when called through the API (#250)? Could we get this PR approved and merged? |
ahmetoner
approved these changes
Dec 16, 2024
|
closes #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #252, language detection is currently broken with larger models when using openai_whisper. Another user proposed a better solution in the linked PR that was not implemented, so I have implemented it here.