Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qeapp.yml not found #255

Closed
unkcpz opened this issue Jul 14, 2022 · 2 comments · Fixed by #256
Closed

qeapp.yml not found #255

unkcpz opened this issue Jul 14, 2022 · 2 comments · Fixed by #256
Assignees
@unkcpz
Labels
bug Something isn't working

Comments

@unkcpz
Copy link
Member

unkcpz commented Jul 14, 2022

Describe the bug
qeapp.yml is load using importlib but not installed as file data which causes the issue when importing modules of qe app. I am curious why there is no exception raise for qe app itself.

/opt/conda/lib/python3.7/importlib/_bootstrap_external.py in open_resource(self, resource)

FileNotFoundError: [Errno 2] No such file or directory: '/home/aiida/.local/lib/python3.7/site-packages/aiidalab_qe/parameters/qeapp.yaml'

To Reproduce
Steps to reproduce the behavior:

  1. Installed QeApp using aiidalab install quantum-espresso
  2. Open a new notebook and execute from aiidalab_qe.widgets import CalcJobOutputFollower
  3. See error

Version (if known)

  • App version: [e.g. v21.07.0]

Additional context
Add any other context about the problem here.
@unkcpz unkcpz added the bug Something isn't working label Jul 14, 2022
@unkcpz unkcpz mentioned this issue Jul 14, 2022
Merged
@csadorf
Copy link
Member

csadorf commented Jul 14, 2022

Could you briefly elaborate on why this bug was never triggered before? Or was it always present, but not noticeable?

@unkcpz
Copy link
Member Author

unkcpz commented Jul 14, 2022

It never shows up since all the functions call of qeApp is from the package. The qeapp.yml file is in the source code folder. I once saw it in SSSP app since I reuse a function of QeApp but then I drop the dependence of that function.

unkcpz added a commit that referenced this issue Aug 17, 2023
@unkcpz
Move files to src layout
cb3ad45 
Using src layout to organize modules (https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/)
This change make it directly detect the package_data import issue of "qeapp.yml" (manifest #255) and css/jinja files in static module.
@unkcpz unkcpz mentioned this issue Aug 17, 2023
Merged
unkcpz added a commit that referenced this issue Aug 17, 2023
@unkcpz
Move files to src layout
d740fbf 
Using src layout to organize modules (https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/)
This change make it directly detect the package_data import issue of "qeapp.yml" (manifest #255) and css/jinja files in static module.

bumpver
unkcpz added a commit that referenced this issue Aug 18, 2023
@unkcpz
Move files to src layout
7e1b550 
Using src layout to organize modules (https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/)
This change make it directly detect the package_data import issue of "qeapp.yml" (manifest #255) and css/jinja files in static module.

bumpver
unkcpz added a commit that referenced this issue Aug 18, 2023
@unkcpz
Move files to src layout (#439)
68e6889 
Using src layout to organize modules (https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/)
This change make it directly detect the package_data import issue of "qeapp.yml" (manifest #255) and css/jinja files in static module.

Fix bumpver error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unkcpz unkcpz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

qeapp.yml install as package_data aiidalab/aiidalab-qe
2 participants
@csadorf @unkcpz