-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sentence case issues #1040
Fix sentence case issues #1040
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
=======================================
Coverage 67.58% 67.58%
=======================================
Files 117 117
Lines 6488 6488
=======================================
Hits 4385 4385
Misses 2103 2103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e60d0b5
to
3cf92c7
Compare
Yes Oh boy, I hadn't looked at all the external notebooks. Let me check.
Well, those are not titles per say, just single keywords. Not sure what we want here. But I agree it should be consistent. Let me try first letter cap in protocol, see how that looks. Handled by #1039 |
@AndresOrtegaGuerrero what do you think? |
@AndresOrtegaGuerrero I removed the headers from PDOS. Extraneous in my opinion. Please have a look at all plugin panels. Let me know if you spot anything else 🙂 |
@edan-bainglass thank you everything looks nice. Perhaps i would suggest to highlight the words molecules and localized orbitals (I am not sure, but just in case they are visible to users). From my side the PR is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.