Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentence case issues #1040

Merged
merged 5 commits into from
Dec 29, 2024

Conversation

edan-bainglass
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.58%. Comparing base (212df84) to head (99be7bc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/utils/search_jobs.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1040   +/-   ##
=======================================
  Coverage   67.58%   67.58%           
=======================================
  Files         117      117           
  Lines        6488     6488           
=======================================
  Hits         4385     4385           
  Misses       2103     2103           
Flag Coverage Δ
python-3.11 67.58% <0.00%> (ø)
python-3.9 67.60% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndresOrtegaGuerrero
Copy link
Member

should we also change this editor ,
image

In the history there are quite some
image

And in the step 2
image

Metal and Insulator have the first letter with CAP, while in the protocol all are not

image The Electron Structure title in results

@edan-bainglass
Copy link
Member Author

should we also change this editor , image

Yes

In the history there are quite some image

Oh boy, I hadn't looked at all the external notebooks. Let me check.

And in the step 2 image

Metal and Insulator have the first letter with CAP, while in the protocol all are not

Well, those are not titles per say, just single keywords. Not sure what we want here. But I agree it should be consistent. Let me try first letter cap in protocol, see how that looks.

image The Electron Structure title in results

Handled by #1039

@edan-bainglass
Copy link
Member Author

And in the step 2 image
Metal and Insulator have the first letter with CAP, while in the protocol all are not

Well, those are not titles per say, just single keywords. Not sure what we want here. But I agree it should be consistent. Let me try first letter cap in protocol, see how that looks.

image

@AndresOrtegaGuerrero what do you think?

@AndresOrtegaGuerrero
Copy link
Member

image In the PDOS plugin, there is a section `Recommendation for Molecules and Localized Orbitals:` I would also suggest including some vertical spacing for the text in this PR to make the text less cramped and more visually appealing.

@edan-bainglass
Copy link
Member Author

@AndresOrtegaGuerrero I removed the headers from PDOS. Extraneous in my opinion.

image

Please have a look at all plugin panels. Let me know if you spot anything else 🙂

@AndresOrtegaGuerrero
Copy link
Member

@edan-bainglass thank you everything looks nice. Perhaps i would suggest to highlight the words molecules and localized orbitals (I am not sure, but just in case they are visible to users). From my side the PR is ready

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edan-bainglass edan-bainglass merged commit 1ad6fd2 into aiidalab:main Dec 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants