Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humanized process status view #1048

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Jan 3, 2025

This PR implements a simpler process status tree.

The tree is

  • human readable
  • collapsible
  • linked with advanced node viewer
  • resettable (collapse all)
  • lazy loaded
  • animated (smooth collapse/expand - may require JS to compute heights - low priority)

TODO

  • Allow for dynamic growing total jobs count for restart workflows
  • Add tests

image

Component of #1042

@edan-bainglass edan-bainglass self-assigned this Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 27.13568% with 145 lines in your changes missing coverage. Please review.

Project coverage is 66.82%. Comparing base (94f23c7) to head (ececc68).

Files with missing lines Patch % Lines
...c/aiidalab_qe/app/result/components/status/tree.py 26.58% 127 Missing ⚠️
...aiidalab_qe/app/result/components/status/status.py 30.76% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   68.01%   66.82%   -1.19%     
==========================================
  Files         112      113       +1     
  Lines        6634     6828     +194     
==========================================
+ Hits         4512     4563      +51     
- Misses       2122     2265     +143     
Flag Coverage Δ
python-3.11 66.82% <27.13%> (-1.18%) ⬇️
python-3.9 66.84% <27.13%> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndresOrtegaGuerrero
Copy link
Member

Some issues you might find related , or that your PR will be addressing
#113
#87

@edan-bainglass
Copy link
Member Author

edan-bainglass commented Jan 3, 2025

Some issues you might find related , or that your PR will be addressing #113 #87

Thanks @AndresOrtegaGuerrero. Indeed related. Especially #87, the ideas of which I already had in mind. Though I was wondering if it should be generalized on the AiiDA level.

class MyWorkChain(WorkChain):
    _humanized_description = "Compute something"

    def get_human_readable_description(self):
        return self._humanized_description

Side question, we are currently on issue 1000+. Do you just happen to remember these ancient issues, or did you go looking? 😅 Asking for my own edification, so I can better find related issues.

@AndresOrtegaGuerrero
Copy link
Member

This was an old discussion , so i new Marnik mentioned this in the past, , but indeed there a need of cleaning old issues.

@edan-bainglass
Copy link
Member Author

This was an old discussion , so i new Marnik mentioned this in the past, , but indeed there a need of cleaning old issues.

No doubt! After the release, I plan to go through all issues, close what has not been automatically closed, and prep the agenda for the next release from all that are open.

@edan-bainglass edan-bainglass force-pushed the simplified-process-status-view branch 3 times, most recently from 266df55 to d2284c4 Compare January 6, 2025 15:40
@edan-bainglass edan-bainglass force-pushed the simplified-process-status-view branch from d2284c4 to ececc68 Compare January 6, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants