-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a download image button for different formats #1056
Adding a download image button for different formats #1056
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1056 +/- ##
==========================================
- Coverage 67.89% 67.83% -0.06%
==========================================
Files 112 112
Lines 6593 6613 +20
==========================================
+ Hits 4476 4486 +10
- Misses 2117 2127 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall straightforward. Before I approve, can you please respond to my comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @AndresOrtegaGuerrero. You can proceed. If possible, could you maybe comment on Plotly's image download API? The plot comes with built-in PNG download. I'm wondering if the modebar could be modified (in a future PR) to include custom buttons for other common formats (likely still using JS).
I used https://plotly.com/python-api-reference/plotly.io.html?highlight=io#module-plotly.io , i dont know if the other option can be modified. |
Here we include a button for downloading the image in different formats