-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with aiida-core=2.6.1 and python 3.11 #760
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
=======================================
Coverage 68.16% 68.16%
=======================================
Files 48 48
Lines 4159 4159
=======================================
Hits 2835 2835
Misses 1324 1324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
f6aec21
to
224caee
Compare
run: pytest -v tests --cov=aiidalab_qe | ||
env: | ||
TAG: ${{ matrix.tag }} | ||
run: pytest -v tests ${{ matrix.aiida-core-version == '2.3' && '--cov=aiidalab_qe' || '' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, running tests with aiida-core >=2.4 takes significantly more time (by 2 minutes), see #766. We can speed up these tests by not collecting the code coverage, i.e. we only collect code coverage with aiida-core==2.3.
With this change the test times are roughly equal.
(note we use a similar trick in aiida-core)
|
||
[tool.pytest.ini_options] | ||
addopts = '--strict-config --strict-markers --durations=30 --durations-min=1 -ra' | ||
filterwarnings = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took these from AWB. There are definitely more warnings that either have to be fixed or ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks fo the work!. LGTM.
for more information, see https://pre-commit.ci
No description provided.