Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with aiida-core=2.6.1 and python 3.11 #760

Merged
merged 19 commits into from
Aug 21, 2024

Conversation

danielhollas
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.16%. Comparing base (3ce7d18) to head (4b68ca3).
Report is 48 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #760   +/-   ##
=======================================
  Coverage   68.16%   68.16%           
=======================================
  Files          48       48           
  Lines        4159     4159           
=======================================
  Hits         2835     2835           
  Misses       1324     1324           
Flag Coverage Δ
python-3.10 ?
python-3.11 68.16% <ø> (?)
python-3.9 68.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@danielhollas danielhollas changed the title Tests with aiida-core=2.6.1 Test with aiida-core=2.6.1 Jul 24, 2024
run: pytest -v tests --cov=aiidalab_qe
env:
TAG: ${{ matrix.tag }}
run: pytest -v tests ${{ matrix.aiida-core-version == '2.3' && '--cov=aiidalab_qe' || '' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, running tests with aiida-core >=2.4 takes significantly more time (by 2 minutes), see #766. We can speed up these tests by not collecting the code coverage, i.e. we only collect code coverage with aiida-core==2.3.
With this change the test times are roughly equal.
(note we use a similar trick in aiida-core)


[tool.pytest.ini_options]
addopts = '--strict-config --strict-markers --durations=30 --durations-min=1 -ra'
filterwarnings = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took these from AWB. There are definitely more warnings that either have to be fixed or ignored.

@danielhollas danielhollas marked this pull request as ready for review July 29, 2024 13:28
@danielhollas danielhollas changed the title Test with aiida-core=2.6.1 Test with aiida-core=2.6.1 and python 3.11 Jul 29, 2024
@unkcpz unkcpz removed their request for review August 8, 2024 08:25
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fo the work!. LGTM.

@danielhollas danielhollas merged commit b9cea17 into aiidalab:main Aug 21, 2024
8 checks passed
@danielhollas danielhollas deleted the test-aiida-2.6.1 branch August 21, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants