Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No untar #792

Closed
wants to merge 3 commits into from
Closed

No untar #792

wants to merge 3 commits into from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jul 31, 2024

fixes #791

  • Not using tar/untar which is already take care by container runtime.
  • Move the home leave thus leave no duplicated data in /opt/ which occupied disk space.

@unkcpz unkcpz requested a review from danielhollas July 31, 2024 13:17
@unkcpz
Copy link
Member Author

unkcpz commented Jul 31, 2024

close because it copy data anyway since home is in volume. I did wrong test by using container without volume.

@unkcpz unkcpz closed this Jul 31, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (94b92f3) to head (380e330).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          45       45           
  Lines        4148     4148           
=======================================
  Hits         2830     2830           
  Misses       1318     1318           
Flag Coverage Δ
python-3.10 68.22% <ø> (ø)
python-3.9 68.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

~0.5 s overhead with tar
1 participant