-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code/Pseudos setup: Separate frontend from backend #796
Conversation
9f4e503
to
e936230
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 68.22% 68.19% -0.03%
==========================================
Files 45 48 +3
Lines 4148 4157 +9
==========================================
+ Hits 2830 2835 +5
- Misses 1318 1322 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @danielhollas, would you mind to separate the renaming in to a commit, it is a bit hard to see what had changed. |
I am not quite sure what you mean, and not sure how to separate it. It's not really renaming, it's a code split. The backend code was moved from For example, most of the code from |
Ah, okay, I thought it was rename and changes. If it is split, then nothing too much can be simplified. I am reviewing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danielhollas, looking forward to see next PR how you invoke from CLI to avoid threading issue.
This is a preparatory PR for refactoring the code setup. It is imho better to separate the frontend (widgets that are displayed in the app) from the routines that actually install stuff in the backend and in the CLI. In this PR, I only move code, and don't do any actual changes yet.
As an immediate advantage, just executing
python -m aiidalab_qe --help
got noticeably faster since we no longer import the rest of the app.In the next PR, instead of importing the install routines in the widgets, we can simply invoke the CLI from a subprocess. That way we do not need to worry about the threading issues, which in turn will allow us to get rid of generating the code setup code and execute it directly.