Skip to content

Commit

Permalink
🐛 Fix dry_run in BaseSubmissionController
Browse files Browse the repository at this point in the history
The `submit_new_batch` method fails when setting `dry_run = True`, as it
attempts to index a `set` which raises a `TypeError`. This issue is fixed
by converting the `set` to a `list`.
  • Loading branch information
t-reents authored Feb 19, 2024
1 parent cf9d6f0 commit f83a7f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion aiida_submission_controller/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def submit_new_batch(self, dry_run=False, sort=False, verbose=False):
"""Submit a new batch of calculations, ensuring less than self.max_concurrent active at the same time."""
CMDLINE_LOGGER.level = logging.INFO if verbose else logging.WARNING

extras_to_run = set(self.get_all_extras_to_submit()).difference(self._check_submitted_extras())
extras_to_run = list(set(self.get_all_extras_to_submit()).difference(self._check_submitted_extras()))

if sort:
extras_to_run = sorted(extras_to_run)
Expand Down

0 comments on commit f83a7f9

Please sign in to comment.