Add sleep argument to submit_new_batch and fix verbose
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-reents
force-pushed
the
imp/submit_new_batch
branch
from
20c553a
to
a9367c4
Compare
The `submit_new_batch` method fails if `verbose` is set to `True`, as it refers to the `parent_group` to get the total number of submissions. When using the `BaseSubmissionController`, this attribute is not specified. To fix the `verbose` option for the `BaseSubmissionController` and `FromGroupSubmissionController`, the number of submissions is defined by the number of `all extras to `submit`.
mbercx
force-pushed
the
imp/submit_new_batch
branch
from
a9367c4
to
888b656
Compare
Currently, the number of submitted `WorkChain`s is determined by the number of available slots. This is not the expected behavior, as this number might be unequal to 0, causing a logging message that states that `n` `WorkChain`s have been submitted, even though no processes were left.
|
I just encountered another small bug when setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mbercx!
This PR contains a few small commits. Since they are all very small, I decided to combine them in a single PR.
I removed the language version in the
black pre-commithook. To the best of my knowledge, this is not really necessary and caused problems when developing in an environment with python 3.10. Please correct me if I'm wrong, so that I can revert this change. (In general, the.pre-commit-config.yamlmight need to be revisited anyway, as some versions are quite old. Same for thepyproject.toml, e.g. do we want to supportaiida 1.0?)I added an optional sleep argument to enable a possible delay. In the current version, the delay is only used after a successful submission. This closes ✨ NEW: Add a
sleepargument tosubmit_new_batch#11When using the
BaseSubmissionControllerand settingverbose=True, an error is raised, as the total number of submissions is determined based on the number of nodes in theparent_group, which is aFromGroupSubmissionControllerproperty only. To fix this, the number of submissions is now determined by the length ofall_extras_to_submit, which shouldn't change the logic, as the nodes in theparent_groupare also identified by a unique set of extras.