[WIP] Correct resolution of local resources/images #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress (missing test cases and docs), sharing before being finished to get feedback about the implementation/logic when resolving the local links.
The checkers
MissingImageFilesChecker
andMissingLocalResourcesChecker
are now using two directories to resolve the links, the base directory (sourceDir
) to resolve absolute links (ones that start with/
) and the directory where the file is to resolve relative links (file.html
,./file.html
,../file.html
).The directory where the file is is obtained from the
HtmlPage
, which is now exposing theFile
it belongs to.Both checkers end up doing the same logic so it might worth extracting a base class.
Fix for #210 and, eventually, #153.