Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Correct resolution of local resources/images #213

Merged
merged 1 commit into from
Sep 15, 2018

Conversation

thc202
Copy link
Contributor

@thc202 thc202 commented Sep 14, 2018

This is still work in progress (missing test cases and docs), sharing before being finished to get feedback about the implementation/logic when resolving the local links.

The checkers MissingImageFilesChecker and MissingLocalResourcesChecker are now using two directories to resolve the links, the base directory (sourceDir) to resolve absolute links (ones that start with /) and the directory where the file is to resolve relative links (file.html, ./file.html, ../file.html).

The directory where the file is is obtained from the HtmlPage, which is now exposing the File it belongs to.
Both checkers end up doing the same logic so it might worth extracting a base class.

Fix for #210 and, eventually, #153.

@gernotstarke gernotstarke merged commit c473806 into aim42:1.0.0-RC-2 Sep 15, 2018
@thc202 thc202 deleted the local-relative-paths branch February 15, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants