Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/aim42/htmlSanityCheck/issues/282 #283

Merged
merged 3 commits into from
Apr 14, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ plugins {
id 'groovy'
id 'java'
id "com.gradle.plugin-publish" version "0.9.10"

// to report build results back to gradle.org
id 'com.gradle.build-scan' version '2.2.1'

}

repositories {
Expand All @@ -29,21 +25,21 @@ repositories {

dependencies {

testCompile(
testImplementation(
'junit:junit:4.12',
'org.spockframework:spock-core:1.2-groovy-2.5')

compile gradleApi()

compile group: 'org.apache.logging.log4j', name: 'log4j-api', version: '2.3'
implementation gradleApi()

implementation group: 'org.apache.logging.log4j', name: 'log4j-api', version: '2.3'

// since gradle 4.6, annotation processors shall be explicitly declared
// (instead of just having them in the compile-group)
annotationProcessor 'org.apache.logging.log4j:log4j-core:2.3'


// jsoup is our awesome html parser, see jsoup.org
compile group: 'org.jsoup', name: 'jsoup', version: '1.11.3'
implementation group: 'org.jsoup', name: 'jsoup', version: '1.11.3'


} // dependencies
Expand Down
3 changes: 3 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
HtmlSanityCheck - ChangeLog

V 1.3.snapshot
Jan 2021: try to fix https://github.com/aim42/htmlSanityCheck/issues/282

V.1.0.0-RC-2
Oct 2018: enhanced configurability, fixed several bugs, released version on gradle plugin portal

Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
8 changes: 5 additions & 3 deletions settings.gradle
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
rootProject.name = 'htmlSanityCheck'
plugins {
// to report build results back to gradle.org
id "com.gradle.enterprise" version "3.5.1"
}

enableFeaturePreview('STABLE_PUBLISHING')
rootProject.name = 'htmlSanityCheck'

include 'docToolchain'

Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ class HtmlSanityCheckTask extends DefaultTask {

// configurable timeout for http-requests (used by @BrokenHttpLinksChecker)
// defaults to 5000 (msecs)
@Optional
// java primitives must not be marked as @Optional
@Input
int httpConnectionTimeout = 5000

// shall localhost-URLs lead to warnings?
@Optional
// java primitives must not be marked as @Optional
@Input
boolean ignoreLocalHost = false

// shall numerical IP addresses lead to warnings?
@Optional
// java primitives must not be marked as @Optional
@Input
boolean ignoreIPAddresses = false

Expand Down