Refactor/config #46
Open
Refactor/config #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicl-nno
requested changes
Jan 27, 2025
Comment on lines
+9
to
+20
| redis_host (str): The hostname of the Redis server. Defaults to "localhost". | ||
| redis_port (int): The port number of the Redis server. Defaults to 6379. | ||
| redis_prefix (str): Prefix for keys used in Redis. Defaults to "llm-api". | ||
| rabbit_host (str): The hostname of the RabbitMQ server. Defaults to "localhost". | ||
| rabbit_port (int): The port number of the RabbitMQ server. Defaults to 5672. | ||
| rabbit_login (str): The username for RabbitMQ authentication. Defaults to "admin". | ||
| rabbit_password (str): The password for RabbitMQ authentication. Defaults to "admin". | ||
| queue_name (str): The name of the RabbitMQ queue to use. Defaults to "llm-api-queue". | ||
| model_path (str): Path to the model being used. Defaults to None. | ||
| token_len (int): The maximum length of tokens for processing by the model. Defaults to None. | ||
| tensor_parallel_size (int): The size of tensor parallelism for distributed processing. Defaults to None. | ||
| gpu_memory_utilisation (float): The percentage of GPU memory utilization for the model. Defaults to None. |
There was a problem hiding this comment.
Не принципиально, но стоит ли дублировать тут type hint-ы, если они есть ниже?
Comment on lines
+25
to
+31
| redis_host: str = "localhost", | ||
| redis_port: int = 6379, | ||
| redis_prefix: str = "llm-api", | ||
| rabbit_host: str = "localhost", | ||
| rabbit_port: int = 5672, | ||
| rabbit_login: str = "admin", | ||
| rabbit_password: str = "admin", |
There was a problem hiding this comment.
Думаю лучше убрать такие дефолтные значения, особенно если они реальные.
There was a problem hiding this comment.
в целом это дефолтный порты и пароли от редиса и rabbit
There was a problem hiding this comment.
Если так, то ок. Но все равно бы не дублировал их в двух местах
Comment on lines
+76
to
+89
| return Config( | ||
| env_vars.get("REDIS_HOST", "localhost"), | ||
| int(env_vars.get("REDIS_PORT", "6379")), | ||
| env_vars.get("REDIS_PREFIX", "llm-api"), | ||
| env_vars.get("RABBIT_MQ_HOST", "localhost"), | ||
| int(env_vars.get("RABBIT_MQ_PORT", "5672")), | ||
| env_vars.get("RABBIT_MQ_LOGIN", "admin"), | ||
| env_vars.get("RABBIT_MQ_PASSWORD", "admin"), | ||
| env_vars.get("QUEUE_NAME", "llm-api-queue"), | ||
| env_vars.get("MODEL_PATH"), | ||
| int(env_vars.get("TOKENS_LEN", "16384")), | ||
| int(env_vars.get("TENSOR_PARALLEL_SIZE", "2")), | ||
| float(env_vars.get("GPU_MEMORY_UTILISATION", "0.9")), | ||
| ) |
There was a problem hiding this comment.
Тут аналогично - если такой сетап нужен для тестов, то лучше создать отдельный env-файл с нужными значениями.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.