Aiohttp2 support+ssl fix #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-urth
commented
Apr 5, 2017
a-urth
commented
- add aiohttp2 compatibility
- change tox respectively
- fix ssl exception handling
- add ssl_context to aiohttp connector
|
And about aiodns support - since its not used by aiohttp without explicit AsyncResolver usage, only possibility for aiodns errors its if session with corresponding resolver will be passed as parameter. I propose:
|
hellysmile
reviewed
Apr 5, 2017
aioelasticsearch/connection.py
Outdated
| } | ||
| session_kwargs = {'auth': self.http_auth} | ||
|
|
||
| if AIOHTTP_2: |
There was a problem hiding this comment.
Как я токошо узнал начиная с 1.3 (или мб раньше) оно и так None по дефолту, а дефалтный в 5 минут ставится в request
added 6 commits
April 5, 2017 19:12
hellysmile
reviewed
Apr 26, 2017
| SSLError) | ||
| from yarl import URL | ||
| from yarl import URL # noqa # isort:skip |
There was a problem hiding this comment.
module level import not on the top because of if statement for aiohttp
|
|
||
| _exc = str(exc) | ||
| # aiohttp wraps ssl error | ||
| if 'SSL: CERTIFICATE_VERIFY_FAILED' in _exc: |
aioelasticsearch/connection.py
Outdated
| from elasticsearch.connection import Connection | ||
| from elasticsearch.exceptions import (ConnectionError, ConnectionTimeout, | ||
|
|
||
| from .compat import AIOHTTP_2, create_future # isort:skip |
There was a problem hiding this comment.
Own party level impoort please
| @@ -54,51 +63,118 @@ def __init__( | |||
| connector=aiohttp.TCPConnector( | |||
| limit=maxsize, | |||
| use_dns_cache=kwargs.get('use_dns_cache', False), | |||
| ssl_context=ssl_context, | |||
There was a problem hiding this comment.
We need to double check one more time list of parameters from init here...
There was a problem hiding this comment.
what exactly to double check and what for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.