Fix StreamResponse equality (#3107)

aio-libs · Jun 26, 2018 · 3a65252 · 3a65252
1 parent 80b8d7a
commit 3a65252
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/CHANGES/3100.bugfix b/CHANGES/3100.bugfix
@@ -0,0 +1 @@
+Fix `StreamResponse` equality, now that they are `MutableMapping` objects.
diff --git a/aiohttp/web_response.py b/aiohttp/web_response.py
@@ -432,6 +432,9 @@ def __iter__(self):
     def __hash__(self):
         return hash(id(self))
 
+    def __eq__(self, other):
+        return self is other
+
 
 class Response(StreamResponse):
 

diff --git a/tests/test_web_response.py b/tests/test_web_response.py
@@ -82,6 +82,14 @@ def test_stream_response_hashable():
     hash(StreamResponse())
 
 
+def test_stream_response_eq():
+    resp1 = StreamResponse()
+    resp2 = StreamResponse()
+
+    assert resp1 == resp1
+    assert not resp1 == resp2
+
+
 def test_stream_response_is_mutable_mapping():
     resp = StreamResponse()
     assert isinstance(resp, collections.MutableMapping)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix `StreamResponse` equality, now that they are `MutableMapping` objects.