Display a hint if you forget to define get_application()

aio-libs · Jul 30, 2017 · 5219adf · 5219adf
1 parent 8071947
commit 5219adf
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/aiohttp/test_utils.py b/aiohttp/test_utils.py
@@ -374,7 +374,7 @@ def get_app(self):
         Use .get_application() coroutine instead
 
         """
-        pass  # pragma: no cover
+        raise RuntimeError("Did you forget to define get_application()?")
 
     def setUp(self):
         self.loop = setup_test_loop()

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -5,7 +5,7 @@
 import pytest
 
 
-pytest_plugins = 'aiohttp.pytest_plugin'
+pytest_plugins = ['aiohttp.pytest_plugin', 'pytester']
 
 
 _LoggingWatcher = collections.namedtuple("_LoggingWatcher",

diff --git a/tests/test_test_utils.py b/tests/test_test_utils.py
@@ -324,3 +324,18 @@ def test_no_custom_client_session(test_client, loop):
     app = _create_example_app()
     with _TestClient(_TestServer(app, loop=loop), loop=loop) as client:
         assert isinstance(client.session, aiohttp.ClientSession)
+
+
+def test_testcase_no_app(testdir, loop):
+    testdir.makepyfile(
+        """
+        from aiohttp.test_utils import AioHTTPTestCase
+
+
+        class InvalidTestCase(AioHTTPTestCase):
+            def test_noop(self):
+                pass
+        """)
+    result = testdir.runpytest()
+    result.assert_outcomes(failed=1)
+    result.stdout.fnmatch_lines(["*RuntimeError*"])