make_mocked_request: subscriptable default app

aio-libs · Aug 5, 2018 · 908684c · 908684c
1 parent cf3a384
commit 908684c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/aiohttp/test_utils.py b/aiohttp/test_utils.py
@@ -448,7 +448,7 @@ def teardown_test_loop(loop, fast=False):
 
 
 def _create_app_mock():
-    app = mock.Mock()
+    app = mock.MagicMock()
     app._debug = False
     app.on_response_prepare = Signal(app)
     app.on_response_prepare.freeze()

diff --git a/tests/test_test_utils.py b/tests/test_test_utils.py
@@ -189,6 +189,11 @@ def test_make_mocked_request_app():
     assert req.app is app
 
 
+def test_make_mocked_request_app_doesnt_crash_on_key_access():
+    req = make_mocked_request('GET', '/')
+    req.app["accessing this shouldn't crash"]
+
+
 def test_make_mocked_request_match_info():
     req = make_mocked_request('GET', '/', match_info={'a': '1', 'b': '2'})
     assert req.match_info == {'a': '1', 'b': '2'}