Fix incrorect base class of ClientConnectorSSLError (#2563)

aio-libs · Nov 27, 2017 · b7084cf · b7084cf
1 parent 0fe3217
commit b7084cf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGES/2563.bugfix b/CHANGES/2563.bugfix
@@ -0,0 +1 @@
+Change base class of ClientConnectorSSLError to ClientSSLError from ClientConnectorError.
diff --git a/aiohttp/client_exceptions.py b/aiohttp/client_exceptions.py
@@ -175,13 +175,13 @@ class ClientSSLError(ClientConnectorError):
     certificate_errors_bases = (ClientSSLError, ssl.CertificateError,)
 
     ssl_errors = (ssl.SSLError,)
-    ssl_error_bases = (ClientConnectorError, ssl.SSLError)
+    ssl_error_bases = (ClientSSLError, ssl.SSLError)
 else:  # pragma: no cover
     certificate_errors = tuple()
     certificate_errors_bases = (ClientSSLError, ValueError,)
 
     ssl_errors = tuple()
-    ssl_error_bases = (ClientConnectorError,)
+    ssl_error_bases = (ClientSSLError,)
 
 
 class ClientConnectorSSLError(*ssl_error_bases):

diff --git a/tests/test_connector.py b/tests/test_connector.py
@@ -1504,7 +1504,7 @@ def handler(request):
             self.loop.run_until_complete(session.request('get', url))
 
         self.assertIsInstance(ctx.value.os_error, ssl.SSLError)
-        self.assertTrue(ctx.value, aiohttp.ClientSSLError)
+        self.assertIsInstance(ctx.value, aiohttp.ClientSSLError)
 
         session.close()
         conn.close()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Change base class of ClientConnectorSSLError to ClientSSLError from ClientConnectorError.