RuntimeError raised when a Redirect doesn't have a Location or URI HTTP header

[PCManticore]

Long story short

As per title, whenever a redirect response doesn't have a Location or a URI HTTP header, a RuntimeError will be raised by aiohttp. While this is indeed a problem, I think that raising RuntimeError seems a bit too much, since now I have to handle it explicitly in my code, rather than catching an aiohttp exception

Expected behaviour

For another exception, particular to aiohttp, to be raised, so that we can handle this case from our code, without hiding other bugs.

Actual behaviour

RuntimeError gets raised

Steps to reproduce

import aiohttp
import asyncio

async def fetch(session, url):
        async with session.get(url) as response:
            return await response.text()

async def main():
    async with aiohttp.ClientSession() as session:
        html = await fetch(session, 'http://www.droidreport.com/googles-market-android-wearables-7173')
        print(html)

loop = asyncio.get_event_loop()
loop.run_until_complete(main())

Your environment

aiohttp==2.0.7
Python 3.6

[asvetlov]

Well, a new class in http_exceptions.py derived from BadHttpMessage sounds like a good solution.

Would you make a PR?

[PCManticore]

Sure!

[asvetlov]

Please note: procedure for adding changes to CHANGES.rst will be changed on #2010 merging.
I expect to finish the work in a few hours

[asvetlov]

Sorry, I misleaded you. Proper exception class should derive from ClientResponseError.
Fixed by 9ff2e40

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.