Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8699/11f0e7f backport][3.11] Reduce code indent in ResponseHandler.data_received #10056

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 27, 2024

(cherry picked from commit 11f0e7f)

@bdraco bdraco changed the title Reduce code indent in ResponseHandler.data_received (#8699) [PR #8699/11f0e7f backport][3.11] Reduce code indent in ResponseHandler.data_received Nov 27, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Nov 27, 2024
@bdraco bdraco marked this pull request as ready for review November 27, 2024 04:01
@bdraco bdraco requested a review from asvetlov as a code owner November 27, 2024 04:01
Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #10056 will not alter performance

Comparing patchback/backports/3.11/11f0e7f0a9be7ab27036a49ff13e318ed03b769a/pr-8699 (433e921) with 3.11 (1a6fafe)

Summary

✅ 44 untouched benchmarks

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (1a6fafe) to head (433e921).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11   #10056      +/-   ##
==========================================
+ Coverage   98.03%   98.05%   +0.01%     
==========================================
  Files         122      122              
  Lines       36931    36970      +39     
  Branches     4448     4452       +4     
==========================================
+ Hits        36207    36252      +45     
+ Misses        543      541       -2     
+ Partials      181      177       -4     
Flag Coverage Δ
CI-GHA 97.94% <100.00%> (+0.01%) ⬆️
OS-Linux 97.64% <100.00%> (+0.01%) ⬆️
OS-Windows 94.55% <97.10%> (+0.02%) ⬆️
OS-macOS 96.76% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.62% <100.00%> (+0.01%) ⬆️
Py-3.10.15 97.20% <100.00%> (+0.05%) ⬆️
Py-3.11.10 97.23% <100.00%> (+0.01%) ⬆️
Py-3.11.9 96.69% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 97.71% <100.00%> (+0.01%) ⬆️
Py-3.13.0 97.71% <100.00%> (+0.01%) ⬆️
Py-3.9.13 96.55% <100.00%> (+0.01%) ⬆️
Py-3.9.20 97.13% <100.00%> (+0.02%) ⬆️
Py-pypy7.3.16 96.69% <100.00%> (+0.01%) ⬆️
VM-macos 96.76% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.64% <100.00%> (+0.01%) ⬆️
VM-windows 94.55% <97.10%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 27, 2024 04:07
@bdraco bdraco merged commit 7e628f4 into 3.11 Nov 27, 2024
34 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/11f0e7f0a9be7ab27036a49ff13e318ed03b769a/pr-8699 branch November 27, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant