Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine executor jobs in FileResponse sendfile_fallback #10059

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Combine executor jobs in FileResponse sendfile_fallback #10059

merged 2 commits into from
Nov 27, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 27, 2024

There were two executor jobs right next to each other than could be combined to avoid a the overhead of second context
switch

@bdraco
Combine executor jobs in FileResponse sendfile_fallback
c7825a7 
There were two executor jobs right next to each other
than could be combined to avoid a second context
switch
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 27, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #10059 will not alter performance

Comparing combine_sendfile_fallback_executor_jobs (55ca619) with master (12372d7)

Summary

✅ 44 untouched benchmarks

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (11f0e7f) to head (55ca619).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #10059   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         121      121           
  Lines       36789    36789           
  Branches     4395     4394    -1     
=======================================
+ Hits        36330    36332    +2     
+ Misses        312      311    -1     
+ Partials      147      146    -1
Flag Coverage Δ
CI-GHA 98.64% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.33% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.17% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.43% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.28% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.87% <100.00%> (+0.05%) ⬆️
Py-3.11.10 97.87% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.33% <100.00%> (-0.01%) ⬇️
Py-3.12.7 98.39% <100.00%> (-0.01%) ⬇️
Py-3.13.0 98.38% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.20% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.74% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.35% <100.00%> (+0.01%) ⬆️
VM-macos 97.43% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.33% <100.00%> (+<0.01%) ⬆️
VM-windows 96.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review November 27, 2024 04:56
@bdraco bdraco requested a review from asvetlov as a code owner November 27, 2024 04:56
@bdraco bdraco enabled auto-merge (squash) November 27, 2024 04:57
@bdraco bdraco merged commit aac6f74 into master Nov 27, 2024
38 checks passed
@bdraco bdraco deleted the combine_sendfile_fallback_executor_jobs branch November 27, 2024 04:57
@patchback Patchback
Copy link
Contributor

patchback bot commented Nov 27, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/aac6f7419b62179d66d52bd0c22d18d609a812ca/pr-10059

Backported as #10062

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 27, 2024
@bdraco @patchback
Combine executor jobs in FileResponse sendfile_fallback (#10059)
b03b3d0 
(cherry picked from commit aac6f74)
@patchback patchback bot mentioned this pull request Nov 27, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Nov 27, 2024 •
edited
Loading

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/aac6f7419b62179d66d52bd0c22d18d609a812ca/pr-10059

Backported as #10063

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 27, 2024
@bdraco @patchback
Combine executor jobs in FileResponse sendfile_fallback (#10059)
a5f7bc5 
(cherry picked from commit aac6f74)
@patchback patchback bot mentioned this pull request Nov 27, 2024
Merged
bdraco added a commit that referenced this pull request Nov 27, 2024
@patchback @bdraco
[PR #10059/aac6f741 backport][3.11] Combine executor jobs in FileResp…
1b78cae 
…onse sendfile_fallback (#10062)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Nov 27, 2024
@patchback @bdraco
[PR #10059/aac6f741 backport][3.12] Combine executor jobs in FileResp…
6ee5782 
…onse sendfile_fallback (#10063)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco