Fix bug with https proxy acquired cleanup #1340 #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jettify
reviewed
Dec 5, 2016
|
|
||
| assert 0 == len(conn._acquired[key]) | ||
|
|
||
| sess.close() |
There was a problem hiding this comment.
close is coroutine, and connector should probably be closed too but not sure.
There was a problem hiding this comment.
yield from sess.close() is enough, session takes ownership of connector.
Current coverage is 98.85% (diff: 100%)@@ master #1450 diff @@
==========================================
Files 30 30
Lines 6963 6973 +10
Methods 0 0
Messages 0 0
Branches 1155 1159 +4
==========================================
+ Hits 6882 6893 +11
Misses 40 40
+ Partials 41 40 -1
|
|
Please take a look on Windows failed tests |
|
Tests fails with the message: |
|
Maybe you do mocking too much or not enough? :) |
kserhii
force-pushed
the
https_proxy_cleanup_fix
branch
from
1a1b5d8 to
1dc8631
Compare
kserhii
force-pushed
the
https_proxy_cleanup_fix
branch
from
c2d78cd to
cde1672
Compare
|
The problem was with unclosed proxy transport. Now everything is done. |
|
Perfect! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request fix bug with https proxy acquired cleanup.
When TCPConnector creates a proxy connection, it adds a transport to the acquired and then sends CONNECT request. But after that TCPConnector detach the transport and does not remove them from the acquired. This caused a memory leak when https proxy connection had used.
Are there changes in behavior for the user?
No.
Related issue number
#1340
Checklist
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.