Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1985: Keep a reference to ClientSession in response object #1988

Merged
merged 3 commits into from
Jun 20, 2017

Conversation

asvetlov
Copy link
Member

Fix for #1985

@fafhrd91 is the change good for you?

@codecov-io
Copy link

codecov-io commented Jun 19, 2017

Codecov Report

Merging #1988 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1988      +/-   ##
==========================================
+ Coverage   97.05%   97.05%   +<.01%     
==========================================
  Files          38       38              
  Lines        7672     7674       +2     
  Branches     1339     1339              
==========================================
+ Hits         7446     7448       +2     
  Misses        102      102              
  Partials      124      124
Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.19% <100%> (+0.02%) ⬆️
tests/autobahn/client.py 97.07% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99423d5...8596e72. Read the comment docs.

@fafhrd91
Copy link
Member

you should set session to None in _cleanup_writer, just in case

@asvetlov
Copy link
Member Author

Done.
Honestly I think it's not necessary: request and response have an unidirection reference to session but the session doesn't keep references to req/rep. Thus we have no circle and regular decref should release everything very well.

@asvetlov asvetlov merged commit 179bf0a into master Jun 20, 2017
@asvetlov asvetlov deleted the keep_session_reference branch June 20, 2017 08:16
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants