Fix bad variable used #2034
Merged
Fix bad variable used #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2034 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 38 38
Lines 7700 7700
Branches 1347 1347
=======================================
Hits 7473 7473
Misses 103 103
Partials 124 124
Continue to review full report at Codecov.
|
|
Good catch! |
cecton
added a commit
to cecton/aiohttp
that referenced
this pull request
Jul 7, 2017
asvetlov
pushed a commit
that referenced
this pull request
Jul 10, 2017
* Improve tox ini (#2031) * Improve tox.ini to be able to run only some tests This change will make tox use posargs if there are any or fallback to "tests" args (which will run the all the tests). You can now use this command to start a specific test: tox -e py35 -- -x tests/test_client_connection.py * Add Python 3.6 to the testing environment * Fix bad variable used (#2034)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
It fixes a wrong variable being used. This PR could be used for more than that in the scope of #2032
Are there changes in behavior for the user?
Not really.
Related issue number
#2032
Checklist
CONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.