Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with pytest 3.3+ #2573

Merged
merged 4 commits into from
Nov 29, 2017
Merged

Fix compatibility with pytest 3.3+ #2573

merged 4 commits into from
Nov 29, 2017

Conversation

asvetlov
Copy link
Member

Fixes #2565

@asvetlov asvetlov changed the base branch from master to 2.3 November 29, 2017 18:59
@codecov-io
Copy link

codecov-io commented Nov 29, 2017 •
edited
Loading

Codecov Report

Merging #2573 into 2.3 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3    #2573      +/-   ##
==========================================
+ Coverage   97.36%   97.37%   +0.01%     
==========================================
  Files          39       39              
  Lines        8260     8257       -3     
  Branches     1439     1438       -1     
==========================================
- Hits         8042     8040       -2     
  Misses         95       95              
+ Partials      123      122       -1
Impacted Files Coverage Δ
aiohttp/pytest_plugin.py 98.65% <100%> (+1.28%) ⬆️
aiohttp/client_reqrep.py 97.36% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5577631...ceb986d. Read the comment docs.

@asvetlov asvetlov merged commit c713b57 into 2.3 Nov 29, 2017
@asvetlov asvetlov deleted the fix-pytest-3.3 branch November 29, 2017 23:43
@asvetlov asvetlov mentioned this pull request Nov 29, 2017
Closed
RonnyPfannschmidt
RonnyPfannschmidt reviewed Nov 30, 2017
View reviewed changes
aiohttp/pytest_plugin.py
@@ -96,8 +96,14 @@ def finalizer():

@pytest.fixture
def fast(request):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would strongly recommend prefixing those fixtures as they have a overly generic name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.
The fixture exists for long time.
Bugfix release is a bad place for such changes.
But PR for master is welcome!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im currently not using aiohttp myself so i'll have to defer

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt left review comments

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asvetlov @codecov-io @RonnyPfannschmidt