Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted YARL version to be less than 1.0 #2664

Closed
wants to merge 2 commits into from

Conversation

netrix
Copy link

@netrix netrix commented Jan 15, 2018

No description provided.

@samuelcolvin
Copy link
Member

@asvetlov would be great to get a patch release with this since it's breaking most usage of aiohttp

@codecov-io
Copy link

codecov-io commented Jan 15, 2018

Codecov Report

Merging #2664 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2664   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files          39       39           
  Lines        7246     7246           
  Branches     1257     1257           
=======================================
  Hits         7100     7100           
  Misses         45       45           
  Partials      101      101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c3879...5864ab5. Read the comment docs.

@kxepal
Copy link
Member

kxepal commented Jan 15, 2018

Thanks for PR! Eventually, proper fix was landed in #2667 .

@netrix netrix closed this Jan 15, 2018
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants