Force Host header to be first in ClientRequest #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there isn't a .netrc file specified by an environment variable, it can be confusing to see warnings about it. If NETRC isn't set, don't warn. Only warn if: a) can't resolve HOME, b) can load, but can't parse file, c) can't find file, d) file appears to exist at the default location but is unreadable for some reason.
GenericStudent
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3342 +/- ##
==========================================
- Coverage 98.03% 97.97% -0.06%
==========================================
Files 44 44
Lines 8039 8069 +30
Branches 1357 1356 -1
==========================================
+ Hits 7881 7906 +25
- Misses 65 68 +3
- Partials 93 95 +2
Continue to review full report at Codecov.
|
|
Hey, please add yourself to contributors and add a news fragment for changelog :) |
asvetlov
requested changes
Oct 15, 2018
* Update async-timeout from 3.0.0 to 3.0.1 * Update cython from 0.28.5 to 0.29 * Update cython from 0.28.5 to 0.29 * Update cython from 0.28.5 to 0.29 * Update gunicorn from 19.8.1 to 19.9.0 * Update tox from 3.5.0 to 3.5.2
…date_auto_headers
asvetlov
approved these changes
Oct 15, 2018
…ent/aiohttp into GenericStudent-host-header-position
|
Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This enforces that the
Hostheader is added / passed first inClientRequestclass under theupdate_auto_headersmethod.Are there changes in behavior for the user?
None
Related issue number
#3265
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.