Fix keepalive connections not being closed in time #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring in 964921d introduced a regression so that `_cleanup()` could be called only once or few times. `_release()` expects `self._cleanup_handle` to be None to add new `weakref_handle`. But when `_cleanup()` called and there are no remaining connections, `self._cleanup_handle` will remain as `<TimerHandle cancelled when=5853434>`, so `_release()` will not have a chance to schedule `_cleanup()` call again. Closes: aio-libs#3296
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #4956 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 43 43
Lines 8932 8933 +1
Branches 1406 1406
=======================================
+ Hits 8718 8719 +1
Misses 95 95
Partials 119 119
Continue to review full report at Codecov.
|
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2020
Co-authored-by: Andrew Svetlov <[email protected]>
💚 Backport successfulThe PR was backported to the following branches:
|
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2020
Co-authored-by: Andrew Svetlov <[email protected]>
💚 Backport successfulThe PR was backported to the following branches:
|
aio-libs-github-bot bot
pushed a commit
that referenced
this pull request
Oct 17, 2020
Backports the following commits to 3.7: - Fix keepalive connections not being closed in time (#4956) Co-authored-by: Vladimir Kamarzin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Refactoring in 964921d introduced a regression so that
_cleanup()could be called only once or few times._release()expectsself._cleanup_handleto be None to add newweakref_handle. But when_cleanup()called and there are no remaining connections,self._cleanup_handlewill remain as<TimerHandle cancelled when=5853434>, so_release()will not have a chance to schedule_cleanup()call again.Closes: #3296
Are there changes in behavior for the user?
Related issue number
#3296
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.