Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #5635/09ac1cbb backport][3.8] Add regression test for #5621 #5636

Merged
merged 1 commit into from
Apr 20, 2021
Merged

[PR #5635/09ac1cbb backport][3.8] Add regression test for #5621 #5636

merged 1 commit into from
Apr 20, 2021

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Apr 20, 2021

This is a backport of PR #5635 as merged into master (09ac1cb).

What do these changes do?

Adds regression test for issue #5621

Are there changes in behavior for the user?

Related issue number

#5621

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@thehesiod
Add regression test for #5621 (#5635)
40ff500 
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit 09ac1cb)
@patchback patchback bot requested a review from asvetlov as a code owner April 20, 2021 17:18
@patchback patchback bot mentioned this pull request Apr 20, 2021
Merged
5 tasks
@webknjaz webknjaz enabled auto-merge (squash) April 20, 2021 17:18
@webknjaz webknjaz merged commit e5da9f2 into 3.8 Apr 20, 2021
@webknjaz webknjaz deleted the patchback/backports/3.8/09ac1cbb4c07b4b3e1872374808512c9bc52f2ab/pr-5635 branch April 20, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webknjaz @thehesiod