Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example in client_quickstart.rst #6363

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Fix example in client_quickstart.rst #6363

merged 2 commits into from
Dec 2, 2021

Conversation

eirenik0
Copy link
Contributor

@eirenik0 eirenik0 commented Dec 1, 2021

What do these changes do?

Fix example in client_quickstart.rst

Are there changes in behavior for the user?

Example will work

Related issue number

Not found

@webknjaz webknjaz added backport-3.9 bot:chronographer:skip This PR does not need to include a change note documentation Improvements or additions to documentation labels Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021 •
edited
Loading

Codecov Report

Merging #6363 (73b5ca5) into master (a233d53) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6363   +/-   ##
=======================================
  Coverage   93.32%   93.32%           
=======================================
  Files         103      103           
  Lines       30377    30377           
  Branches     3058     3058           
=======================================
  Hits        28350    28350           
  Misses       1850     1850           
  Partials      177      177
Flag Coverage Δ
unit 93.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a233d53...73b5ca5. Read the comment docs.

@asvetlov asvetlov merged commit eef86e9 into aio-libs:master Dec 2, 2021
@patchback
Copy link
Contributor

patchback bot commented Dec 2, 2021 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/eef86e9e385e40e0bc02e9226419f78277284e36/pr-6363

Backported as #6364

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 2, 2021
@patchback
Fix example in client_quickstart.rst (#6363)
b64e476 
Co-authored-by: Andrew Svetlov <[email protected]>
(cherry picked from commit eef86e9)
@patchback patchback bot mentioned this pull request Dec 2, 2021
Merged
@patchback
Copy link
Contributor

patchback bot commented Dec 2, 2021 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/eef86e9e385e40e0bc02e9226419f78277284e36/pr-6363

Backported as #6365

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 2, 2021
@patchback
Fix example in client_quickstart.rst (#6363)
7594159 
Co-authored-by: Andrew Svetlov <[email protected]>
(cherry picked from commit eef86e9)
@patchback patchback bot mentioned this pull request Dec 2, 2021
Merged
asvetlov pushed a commit that referenced this pull request Dec 4, 2021
@patchback
Fix example in client_quickstart.rst (#6363) (#6364)
ea5d8ee 
Co-authored-by: Andrew Svetlov <[email protected]>
(cherry picked from commit eef86e9)

Co-authored-by: Se̐rhii Khaly̐mon <[email protected]>
asvetlov added a commit that referenced this pull request Dec 4, 2021
@patchback @asvetlov
Fix example in client_quickstart.rst (#6363) (#6365)
5133867 
Co-authored-by: Andrew Svetlov <[email protected]>
(cherry picked from commit eef86e9)

Co-authored-by: Se̐rhii Khaly̐mon <[email protected]>
Co-authored-by: Andrew Svetlov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:skip This PR does not need to include a change note documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eirenik0 @webknjaz @asvetlov