-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #7306 - Set ClientWebSocketResponse.close_code correctly in concurrent closing scenario #7680
Fix #7306 - Set ClientWebSocketResponse.close_code correctly in concurrent closing scenario #7680
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7680 +/- ##
==========================================
- Coverage 97.36% 97.36% -0.01%
==========================================
Files 106 106
Lines 31630 31648 +18
Branches 3619 3620 +1
==========================================
+ Hits 30797 30813 +16
- Misses 630 632 +2
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 30850ba on top of patchback/backports/3.9/30850babb43a8e28dd2df036776c62fd613d3d89/pr-7680 Backporting merged PR #7680 into master
🤖 @patchback |
@ttsia Thanks for that. If you could create a backport with the above instructions, that'd be great. |
…in concurrent closing scenario (aio-libs#7680) (cherry picked from commit 30850ba)
…nse.close_code correctly in concu… (#7690) This is a backport of PR #7680 as merged into master (30850ba). Fixes the issue when If one asyncio task is waiting on receiving data and another asyncio task is closing the connection. The ClientWebSocketResponse.close_code will be None after connection closed.
…ntWebSocketResponse.close_code correctly in concu… (aio-libs#7690) This is a backport of PR aio-libs#7680 as merged into master (aio-libs@30850ba). Fixes the issue when If one asyncio task is waiting on receiving data and another asyncio task is closing the connection. The ClientWebSocketResponse.close_code will be None after connection closed.
What do these changes do?
Fixes the issue when If one asyncio task is waiting on receiving data and another asyncio task is closing the connection. The ClientWebSocketResponse.close_code will be None after connection closed.
Related issue number
Fixes #7306
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.