Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9851/541d86d backport][3.11] Fix incorrect parsing of chunk extensions with the pure Python parser #9854

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 13, 2024

(cherry picked from commit 541d86d)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 13, 2024
@bdraco bdraco changed the title Fix incorrect parsing of chunk extensions with the pure Python parser (#9851) [PR #9851/541d86d backport][3.11] Fix incorrect parsing of chunk extensions with the pure Python parser Nov 13, 2024
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #9854 will not alter performance

Comparing patchback/backports/3.11/541d86d9e7884590c655876cd40042565293d8df/pr-9851 (a7e4a52) with 3.11 (354489d)

Summary

✅ 24 untouched benchmarks

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (fe0a6e6) to head (a7e4a52).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9854   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         119      119           
  Lines       36349    36366   +17     
  Branches     4358     4361    +3     
=======================================
+ Hits        35620    35638   +18     
  Misses        545      545           
+ Partials      184      183    -1     
Flag Coverage Δ
CI-GHA 97.88% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.58% <100.00%> (-0.01%) ⬇️
OS-Windows 94.43% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.69% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.53% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.09% <100.00%> (-0.05%) ⬇️
Py-3.11.10 97.15% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.61% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 97.65% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.46% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.05% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.61% <77.77%> (-0.01%) ⬇️
VM-macos 96.69% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.58% <100.00%> (-0.01%) ⬇️
VM-windows 94.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review November 13, 2024 14:38
@bdraco bdraco merged commit d24c19e into 3.11 Nov 13, 2024
36 of 37 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/541d86d9e7884590c655876cd40042565293d8df/pr-9851 branch November 13, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant