-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cython to 3.0.0b1, add 3.12 to test matrix #436
Conversation
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 1 1
Lines 61 61
Branches 9 9
=======================================
Hits 60 60
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
In CI, it's probably fine. Through, maybe just for 3.12 for now? |
Maybe also an experimental flag? |
Not sure what that'd achieve though. We can't release a 3.12-compatible tarball without Cython 3.0.0b1 at the moment (it looks like the changes required for Cython 0.29.x are extensive). |
Alright... Fair enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjpieters feel free to merge upon resolving the conflicts.
This release is compatible with Python 3.12a05 (and up). While here, extend the tox configuration to also cover 3.11 and 3.12, and have GitHub test against 3.12.
@mjpieters sorry for the ping, would be possible to get a new release with this PR? this is blocking a PR where I'm adding 3.12 to the testing pipeline 😊 |
@patrick91 I'll take a look in a minute. |
I'll need to make a few metadata adjustments, like removing/replacing dead links, etc. Then, I'll trigger the release pipeline. |
This release is compatible with Python 3.12a05 (and up). While here, extend
the tox configuration to also cover 3.11 and 3.12, and have GitHub test against
3.12.
Related issue number
Fixes #433