Await mode changes #313
Merged
Await mode changes #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is small clean-up pull request which removes some functions that were unnecessarily declared to return promise/thenable and also adds a couple of await when we respond to selection or tab change events from the VS Code window. It's possible that this will solve #308, but since I can't reproduce it, I can't be certain.
There is a more ambitious change that would involve making the core
executefunction of each mode async and awaiting it in the input handler, but I suspect that might make the extension feel a bit laggy, so I'd rather not do that unless we're sure it's going to make a difference.