Update for Swift 5 and Xcode 13.2 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super keen to get this one merged, how can I help? |
|
Sorry for the delay! I'll take a look at this in the next few days and we can get this merged. Thanks for your patience! |
No problem at all! Thank you for open sourcing this component, and let me know if I can help? /cc @kimrypstraHE |
bryankeller
approved these changes
May 27, 2022
There was a problem hiding this comment.
Thanks for doing the migration! I removed the dangling pointer warning fixes from this and did them separately in this PR #106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the codebase for Swift 5
and fixes warnings on Xcode 13.2.Edit by @bryankeller: Removed the warning fixes for dangling pointers. I'll fix this in a separate PR.