Upgrade showkase to the latest stable releases #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinaygaba
commented
Mar 28, 2022
| @@ -108,16 +107,6 @@ allprojects { | |||
| google() | |||
| mavenCentral() | |||
| jcenter() | |||
| maven { url 'https://dl.bintray.com/kotlin/kotlin-eap' } | |||
| } | |||
| if (project.hasProperty('useKsp')) { | |||
There was a problem hiding this comment.
Had to duplicate this in every build.gradle file to get around this build failure that I was seeing locally and on CI - https://github.com/airbnb/Showkase/runs/5713525186?check_suite_focus=true. Wasted too much time to fix this but eventually gave in and just used the workaround that worked for me. I'm open to suggestions if you know a way to fix this build error :(
There was a problem hiding this comment.
Oof I do not know of a way but the workaround seems fine for now.
pmecho
approved these changes
Mar 29, 2022
| @@ -108,16 +107,6 @@ allprojects { | |||
| google() | |||
| mavenCentral() | |||
| jcenter() | |||
| maven { url 'https://dl.bintray.com/kotlin/kotlin-eap' } | |||
| } | |||
| if (project.hasProperty('useKsp')) { | |||
There was a problem hiding this comment.
Oof I do not know of a way but the workaround seems fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@airbnb/showkase-maintainers