Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sample to demonstrate automated screenshot testing with Showkase and Paparazzi #252

Merged
merged 40 commits into from
Oct 29, 2022

Conversation

vinaygaba
Copy link
Collaborator

@vinaygaba vinaygaba commented Aug 14, 2022

Added sample to demonstrate automated screenshot testing with Showkase and Paparazzi. This leverages the example that @alexvanyo created for the Now In Android app https://github.com/android/nowinandroid.

This is purely meant for demo purposes and will be referenced in the documentation that I'm about to add shortly.

@vinaygaba vinaygaba marked this pull request as ready for review August 18, 2022 16:19
Copy link
Contributor

@oas004 oas004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks very nice! Amazing work! 😄 🤩


@Composable
fun VerticalScrollSample() {
Column(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we are not using LazyColumn here? 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, was just added as a sample. No particular reason to add it or skip it 😅

@mochadwi
Copy link

related: android/nowinandroid#101

@vinaygaba vinaygaba merged commit b893d55 into master Oct 29, 2022
@anhanh11001
Copy link

How can you get getMetadata() extension function here? I follow similar approach and also compile my app but never receive this function

@vinaygaba
Copy link
Collaborator Author

@anhanh11001 Sources generated from ksp would need to be registered separately, similar to how it's done in the sample app of the project - #279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants