-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize code generation to be more performant #284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oas004
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 🙌
elihart
reviewed
Dec 13, 2022
.../src/main/java/com/airbnb/android/showkase/processor/writer/ShowkaseBrowserPropertyWriter.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/airbnb/android/showkase/processor/writer/ShowkaseBrowserPropertyWriter.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/airbnb/android/showkase/processor/writer/ShowkaseBrowserPropertyWriter.kt
Outdated
Show resolved
Hide resolved
BenSchwab
approved these changes
Dec 15, 2022
showkase-processor/src/main/java/com/airbnb/android/showkase/processor/ShowkaseProcessor.kt
Outdated
Show resolved
Hide resolved
…ze-metadata-aggregation
…ze-metadata-aggregation
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit an issue with a Jacoco task where it wasn't able to initialize the
XRootCodegen
file anymore as our codebase had reached the limit of components it was able to support. This was specifically happening if you used Jacoco as it tries to do a few things internally that initializes each class that's going to be processed for code coverage.In this PR, I've implemented a couple changes:
ShowkaseMetadata
instance generates a separate file with a top level property. This is good for build times as well as it helps with incremental compilation.RootCodegen
file references these top level properties from the other files. I also removed the top level properties from this Codegen file as those would need to be initialized during init (which Jacoco invokes) and instead directly create the aggregated list of top level properties in the interface method.These two changes will ensure that the initialization of the aggregated class is significantly more light weight and should avoid an issue like this from happening again.
Before
After