Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide dark background for rendering Dark mode previews #385

Merged
merged 3 commits into from
May 29, 2024

Conversation

vinaygaba
Copy link
Collaborator

@vinaygaba vinaygaba commented May 25, 2024

Fixes #289

Notice the background of the dark mode card, specifically the area around the component itself.

Screenshot 2024-05-24 at 9 17 38 PM

Box {
Column(modifier = composableModifier) {
metadata.component()
MaterialTheme(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this was handled at the root screen itself but since I just realized Showkase wasn't really using the theme at all, I'm limit the scope and restrict it to just the dark mode use case.

@vinaygaba vinaygaba merged commit 17f32f9 into master May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Provide dark background for rendering Dark mode previews
1 participant