EpoxyModelGroup with ViewStub

[eboudrant]

I am trying to layout a model group using ViewStub, here the xml :

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="horizontal">

    <!-- First element -->
    <ViewStub
        android:layout_width="60dp"
        android:layout_height="60dp" />

    <!-- Elastic space -->
    <View
        android:layout_width="0dp"
        android:layout_height="match_parent"
        android:layout_weight="1" />

    <!-- And up to 3 elements -->
    <ViewStub
        android:layout_width="60dp"
        android:layout_height="60dp" />
    <ViewStub
        android:layout_width="60dp"
        android:layout_height="60dp" />
    <ViewStub
        android:layout_width="60dp"
        android:layout_height="60dp" />

</LinearLayout>

I am expecting :

But I am seeing this :

Is there any issue with EpoxyModelGroup / ViewStub or is it a miss-use from me ?

Full code is here : eboudrant#9

[eboudrant]

Looks like the stub are removed too early from the layout :

epoxy/epoxy-adapter/src/main/java/com/airbnb/epoxy/ModelGroupHolder.kt

Line 67 in 2de36ba

stubData.removeView()

The position passed in the ViewStubData would not allow to re-position correctly the nested model.

A quick fix would be to remove the view stub when we set the view in ViewStubData :

    fun setView(view: View, useStubLayoutParams: Boolean) {
        // Carry over the stub id manually since we aren't inflating via the stub
        val inflatedId = viewStub.inflatedId
        if (inflatedId != View.NO_ID) {
            view.id = inflatedId
        }

        if (useStubLayoutParams) {
            viewGroup.removeView(viewStub)
            viewGroup.addView(view, position, viewStub.layoutParams)
        } else {
            viewGroup.removeView(viewStub)
            viewGroup.addView(view, position)
        }
    }

But stub's discovery need to be re-written a but as it rely in stub being removed...

[elihart]

Thanks for reporting. good catch, this is definitely wrong.

I'm traveling now, but can fix it early next week - sorry for the issue!

Maybe an easy fix could be to have getNextViewStub add the count of existing stubs to the index of the newly created stub data - I think that would give the correct adjusted position while not requiring a change to the view removal - I'll have to think about it a bit more though.

[elihart]

#676