Fix model group issues #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2019
elihart
force-pushed
the
eli-fix_model_group
branch
from
6a7ee01 to
dddbe98
Compare
eboudrant
reviewed
Feb 5, 2019
| @@ -58,40 +58,31 @@ class ModelGroupHolder : EpoxyHolder() { | |||
| } | |||
|
|
|||
| private fun createViewStubData(viewGroup: ViewGroup): List<ViewStubData> { | |||
| val stubs = ArrayList<ViewStubData>(4) | |||
| return ArrayList<ViewStubData>(4).apply { | |||
There was a problem hiding this comment.
Just curious, why don't you use Kotlin list : mutableListOf<ViewStubData>() ?
There was a problem hiding this comment.
I believe it was so I could give an initial capacity value
There was a problem hiding this comment.
it's a somewhat arbitrary guess - groups are generally small, but non zero size
eboudrant
reviewed
Feb 5, 2019
| @@ -117,7 +108,7 @@ class ModelGroupHolder : EpoxyHolder() { | |||
| if (usingStubs() && stubs.size < modelCount) { | |||
| throw IllegalStateException( | |||
| "Insufficient view stubs for EpoxyModelGroup. " + modelCount + | |||
| " models were provided but only " + stubs.size + " view stubs exist." | |||
| " models were provided but only " + stubs.size + " view stubs exist." | |||
There was a problem hiding this comment.
You could rewrite strings with "...only ${stubs.size} view..."
eboudrant
reviewed
Feb 5, 2019
| @@ -217,7 +210,12 @@ private class ViewStubData( | |||
| } | |||
| } | |||
|
|
|||
| fun removeView() { | |||
| fun resetStub() { | |||
There was a problem hiding this comment.
it's actually used in the holder class in the same file, but ViewStubData is private
There was a problem hiding this comment.
ah, could reduce to internal then ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #672 and #675
Tests were updated to catch these issues