Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated code consistency in builder interfaces #1166

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

elihart
Copy link
Contributor

@elihart elihart commented Apr 12, 2021

The generated files of the builder interfaces could be different across builds because of methods being generated in different orders. This can lead to different cache keys and cache misses.

@elihart elihart requested a review from vinaygaba April 12, 2021 22:46
Copy link
Collaborator

@vinaygaba vinaygaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition 👍

@elihart elihart merged commit 91f6b3e into master Apr 12, 2021
@elihart elihart deleted the eli-sort_interface_methods branch April 12, 2021 23:16
@elihart elihart mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants