Use kotlin dsl marker for model building receivers #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmecho
approved these changes
May 10, 2021
vinaygaba
reviewed
May 11, 2021
| * for building models you cannot incorrectly nest models and also don't see cluttered, incorrect | ||
| * code completion suggestions. | ||
| */ | ||
| @DslMarker |
vinaygaba
reviewed
May 11, 2021
| @@ -1,7 +1,7 @@ | |||
| // Top-level build file where you can add configuration options common to all sub-projects/modules. | |||
| buildscript { | |||
|
|
|||
| ext.KOTLIN_VERSION = "1.4.32" | |||
| ext.KOTLIN_VERSION = "1.5.0" | |||
vinaygaba
approved these changes
May 11, 2021
Merged
|
@elihart My team recently updated to this version, which required over 500 line changes of heavily verbose code. Seeing that this breaking change was needed because "something annoyed you" seems like a good reason to start migrating away from Epoxy. |
|
@martymiller did you see the option to disable this change in #1185? This wasn't just because it annoyed me, it was trying to fix a problem that I expected would cause friction for many other people. If you see something you would like changed please submit a PR to improve the project; after all, it's free, open source software you're using. Regarding migrating away, please do move to Compose as it is simply better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had gotten annoyed by autocomplete suggesting all of our model names inside of building another model - it makes it hard to find the applicable properties of a model as well as enables buggy behavior.
Adding the kotlin dsl marker annotation to both the ModelCollector as well as generated models prevents both of these things.
This is a breaking change if inside of a model building function you reference a property in enclosing EpoxyController - to do so now requires an explicit
this. While being safer and more readable that might require some people to make quite a few updates for this.I was also getting R8 issues that I had to solve by making all modules target java 1.8