-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for default layout in parents if not specified #119
Conversation
Nice! It is a bit complex, but I don't think there is much getting around that. I just merged #120 which adds checks around the
|
I'll look into your implementation! Just wanted to be sure that I understood the problem and did it correctly. |
@Test | ||
public void testGenerateDefaultLayoutMethodFailsIfLayoutNotSpecified() { | ||
JavaFileObject model = JavaFileObjects | ||
.forResource("GenerateDefaultLayoutMethodNoLayout.java"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all these tests!
yep, you understood perfectly, thanks for working on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks :)
#118
The logic ended up more complex than I expected initially. If you have any ideas how to do it easily - I'll gladly fix it.