Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve unchecked call warning for WrappedEpoxyModelClickListener #1337

Merged
merged 1 commit into from
May 19, 2023
Merged

Resolve unchecked call warning for WrappedEpoxyModelClickListener #1337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion epoxy-modelfactorytest/src/test/resources/AllTypesModelViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ public AllTypesModelViewModel_ onClickListener(
this.onClickListener_OnClickListener = null;
}
else {
this.onClickListener_OnClickListener = new WrappedEpoxyModelClickListener(onClickListener);
this.onClickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(onClickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-modelfactorytest/src/test/resources/CallbackPropModelViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public CallbackPropModelViewModel_ onClickListener(
this.onClickListener_OnClickListener = null;
}
else {
this.onClickListener_OnClickListener = new WrappedEpoxyModelClickListener(onClickListener);
this.onClickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(onClickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-modelfactorytest/src/test/resources/ksp/AllTypesModelViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ public AllTypesModelViewModel_ onClickListener(
this.onClickListener_OnClickListener = null;
}
else {
this.onClickListener_OnClickListener = new WrappedEpoxyModelClickListener(onClickListener);
this.onClickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(onClickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-modelfactorytest/src/test/resources/ksp/CallbackPropModelViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public CallbackPropModelViewModel_ onClickListener(
this.onClickListener_OnClickListener = null;
}
else {
this.onClickListener_OnClickListener = new WrappedEpoxyModelClickListener(onClickListener);
this.onClickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(onClickListener);
}
return this;
}
Expand Down
4 changes: 2 additions & 2 deletions epoxy-processor/src/main/java/com/airbnb/epoxy/processor/GeneratedModelWriter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,7 @@ class GeneratedModelWriter(

// This model did not specify a layout in its EpoxyModelClass annotation,
// but its superclass might
classElement.superType?.typeElement
classElement.superClass?.typeElement
?.let { superClass ->
findSuperClassWithClassAnnotation(superClass)
}
Expand Down Expand Up @@ -1413,7 +1413,7 @@ class GeneratedModelWriter(
setBitSetIfNeeded(classInfo, attribute, builder)

val wrapperClickListenerConstructor = CodeBlock.of(
"new \$T(\$L)",
"new \$T<>(\$L)",
ClassNames.EPOXY_WRAPPED_LISTENER,
param.name
)
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/DoNotHashViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public DoNotHashViewModel_ clickListener(
this.clickListener_OnClickListener = null;
}
else {
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener(clickListener);
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/IgnoreRequireHashCodeViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public IgnoreRequireHashCodeViewModel_ clickListener(
this.clickListener_OnClickListener = null;
}
else {
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener(clickListener);
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ModelProcessorTest/testKotlinModel/Model_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public Model_ clickListener(final OnModelClickListener<Model_, Model.Holder> cli
super.setClickListener(null);
}
else {
super.setClickListener(new WrappedEpoxyModelClickListener(clickListener));
super.setClickListener(new WrappedEpoxyModelClickListener<>(clickListener));
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ModelProcessorTest/testKotlinModel/ksp/Model_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public Model_ clickListener(
super.setClickListener(null);
}
else {
super.setClickListener(new WrappedEpoxyModelClickListener(clickListener));
super.setClickListener(new WrappedEpoxyModelClickListener<>(clickListener));
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion ...y-processortest/src/test/resources/ModelWithDataBindingWithoutDonothashBindingModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public ModelWithDataBindingWithoutDonothashBindingModel_ clickListener(
this.clickListener = null;
}
else {
this.clickListener = new WrappedEpoxyModelClickListener(clickListener);
this.clickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ModelWithPrivateViewClickListener_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public ModelWithPrivateViewClickListener_ clickListener(
super.setClickListener(null);
}
else {
super.setClickListener(new WrappedEpoxyModelClickListener(clickListener));
super.setClickListener(new WrappedEpoxyModelClickListener<>(clickListener));
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ModelWithViewClickListener_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public ModelWithViewClickListener_ clickListener(
super.clickListener = null;
}
else {
super.clickListener = new WrappedEpoxyModelClickListener(clickListener);
super.clickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ModelWithViewLongClickListener_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public ModelWithViewLongClickListener_ clickListener(
super.clickListener = null;
}
else {
super.clickListener = new WrappedEpoxyModelClickListener(clickListener);
super.clickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/TestCallbackPropViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public TestCallbackPropViewModel_ listener(
this.listener_OnClickListener = null;
}
else {
this.listener_OnClickListener = new WrappedEpoxyModelClickListener(listener);
this.listener_OnClickListener = new WrappedEpoxyModelClickListener<>(listener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/TestFieldPropCallbackPropViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public TestFieldPropCallbackPropViewModel_ value(
this.value_OnClickListener = null;
}
else {
this.value_OnClickListener = new WrappedEpoxyModelClickListener(value);
this.value_OnClickListener = new WrappedEpoxyModelClickListener<>(value);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/TestFieldPropChildViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ public TestFieldPropChildViewModel_ value(
this.value_OnClickListener = null;
}
else {
this.value_OnClickListener = new WrappedEpoxyModelClickListener(value);
this.value_OnClickListener = new WrappedEpoxyModelClickListener<>(value);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/TestFieldPropDoNotHashOptionViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public TestFieldPropDoNotHashOptionViewModel_ value(
this.value_OnClickListener = null;
}
else {
this.value_OnClickListener = new WrappedEpoxyModelClickListener(value);
this.value_OnClickListener = new WrappedEpoxyModelClickListener<>(value);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion ...-processortest/src/test/resources/TestFieldPropIgnoreRequireHashCodeOptionViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public TestFieldPropIgnoreRequireHashCodeOptionViewModel_ value(
this.value_OnClickListener = null;
}
else {
this.value_OnClickListener = new WrappedEpoxyModelClickListener(value);
this.value_OnClickListener = new WrappedEpoxyModelClickListener<>(value);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/TestFieldPropNullOnRecycleOptionViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public TestFieldPropNullOnRecycleOptionViewModel_ value(
this.value_OnClickListener = null;
}
else {
this.value_OnClickListener = new WrappedEpoxyModelClickListener(value);
this.value_OnClickListener = new WrappedEpoxyModelClickListener<>(value);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/TestManyTypesViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ public TestManyTypesViewModel_ clickListener(
this.clickListener_OnClickListener = null;
}
else {
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener(clickListener);
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion ...essortest/src/test/resources/ViewProcessorTest/testManyTypes/TestManyTypesViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ public TestManyTypesViewModel_ clickListener(
this.clickListener_OnClickListener = null;
}
else {
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener(clickListener);
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion ...rtest/src/test/resources/ViewProcessorTest/testManyTypes/ksp/TestManyTypesViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ public TestManyTypesViewModel_ clickListener(
this.clickListener_OnClickListener = null;
}
else {
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener(clickListener);
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/DoNotHashViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public DoNotHashViewModel_ clickListener(
this.clickListener_OnClickListener = null;
}
else {
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener(clickListener);
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/IgnoreRequireHashCodeViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public IgnoreRequireHashCodeViewModel_ clickListener(
this.clickListener_OnClickListener = null;
}
else {
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener(clickListener);
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/ModelWithPrivateViewClickListener_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public ModelWithPrivateViewClickListener_ clickListener(
super.setClickListener(null);
}
else {
super.setClickListener(new WrappedEpoxyModelClickListener(clickListener));
super.setClickListener(new WrappedEpoxyModelClickListener<>(clickListener));
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/ModelWithViewClickListener_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public ModelWithViewClickListener_ clickListener(
super.clickListener = null;
}
else {
super.clickListener = new WrappedEpoxyModelClickListener(clickListener);
super.clickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/ModelWithViewLongClickListener_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public ModelWithViewLongClickListener_ clickListener(
super.clickListener = null;
}
else {
super.clickListener = new WrappedEpoxyModelClickListener(clickListener);
super.clickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/TestCallbackPropViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public TestCallbackPropViewModel_ listener(
this.listener_OnClickListener = null;
}
else {
this.listener_OnClickListener = new WrappedEpoxyModelClickListener(listener);
this.listener_OnClickListener = new WrappedEpoxyModelClickListener<>(listener);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/TestFieldPropCallbackPropViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public TestFieldPropCallbackPropViewModel_ value(
this.value_OnClickListener = null;
}
else {
this.value_OnClickListener = new WrappedEpoxyModelClickListener(value);
this.value_OnClickListener = new WrappedEpoxyModelClickListener<>(value);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/TestFieldPropChildViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ public TestFieldPropChildViewModel_ value(
this.value_OnClickListener = null;
}
else {
this.value_OnClickListener = new WrappedEpoxyModelClickListener(value);
this.value_OnClickListener = new WrappedEpoxyModelClickListener<>(value);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/TestFieldPropDoNotHashOptionViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public TestFieldPropDoNotHashOptionViewModel_ value(
this.value_OnClickListener = null;
}
else {
this.value_OnClickListener = new WrappedEpoxyModelClickListener(value);
this.value_OnClickListener = new WrappedEpoxyModelClickListener<>(value);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion ...cessortest/src/test/resources/ksp/TestFieldPropIgnoreRequireHashCodeOptionViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public TestFieldPropIgnoreRequireHashCodeOptionViewModel_ value(
this.value_OnClickListener = null;
}
else {
this.value_OnClickListener = new WrappedEpoxyModelClickListener(value);
this.value_OnClickListener = new WrappedEpoxyModelClickListener<>(value);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/TestFieldPropNullOnRecycleOptionViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public TestFieldPropNullOnRecycleOptionViewModel_ value(
this.value_OnClickListener = null;
}
else {
this.value_OnClickListener = new WrappedEpoxyModelClickListener(value);
this.value_OnClickListener = new WrappedEpoxyModelClickListener<>(value);
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion epoxy-processortest/src/test/resources/ksp/TestManyTypesViewModel_.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ public TestManyTypesViewModel_ clickListener(
this.clickListener_OnClickListener = null;
}
else {
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener(clickListener);
this.clickListener_OnClickListener = new WrappedEpoxyModelClickListener<>(clickListener);
}
return this;
}
Expand Down