Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include canvas in ItemTouchHelper swipe callback #280

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Include canvas in ItemTouchHelper swipe callback #280

merged 1 commit into from
Sep 12, 2017

Conversation

elihart
Copy link
Contributor

@elihart elihart commented Sep 12, 2017

This changes the onSwipeProgressChanged callback in EpoxyTouchHelper to take Canvas as a parameter. This will allows users to draw to the canvas to have more control in how the swipe is animated.

This is a breaking change to the touch helper API. I am ok with this because

  1. It is fairly new and won't have much usage yet
  2. This should be helpful to people
  3. It is an easy change to make and probably won't have to be updated in many places

@skywalkerDavid
Copy link

LGTM, thank you for adding this. 👍

@elihart elihart merged commit f5218b5 into master Sep 12, 2017
@elihart elihart deleted the eli-touch_helper_canvas branch September 12, 2017 22:49
@elihart elihart mentioned this pull request Sep 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skywalkerDavid skywalkerDavid skywalkerDavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elihart @skywalkerDavid