Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async improvements #509

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Async improvements #509

merged 1 commit into from
Aug 25, 2018

Conversation

elihart
Copy link
Contributor

@elihart elihart commented Aug 24, 2018

@elihart elihart force-pushed the eli-async_diff_post branch from a7c568e to ef686f2 Compare August 24, 2018 20:34
@elihart elihart force-pushed the eli-async_diff_post branch from ef686f2 to 5c8e315 Compare August 24, 2018 20:44
@elihart elihart merged commit 6f75110 into master Aug 25, 2018
@elihart elihart deleted the eli-async_diff_post branch August 25, 2018 01:40
@elihart elihart mentioned this pull request Aug 25, 2018
Merged
baoti
baoti reviewed Sep 11, 2018
View reviewed changes
epoxy-adapter/src/main/java/com/airbnb/epoxy/AsyncEpoxyController.java
*/
public AsyncEpoxyController(boolean enableAsync) {
this(true, true);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enableAsync is unused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baoti whoops! thanks a lot for catching that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baoti baoti baoti left review comments

@gpeal gpeal gpeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elihart @gpeal @baoti