Enable recycling of views within groups #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboudrant
reviewed
Jan 14, 2019
epoxy-adapter/build.gradle
Outdated
| @@ -22,6 +22,7 @@ dependencies { | |||
| implementation rootProject.deps.androidAnnotations | |||
| implementation rootProject.deps.androidRecyclerView | |||
| implementation rootProject.deps.androidDesignLibrary | |||
| implementation rootProject.deps.kotlin | |||
There was a problem hiding this comment.
Like Checkstyle for Java, do you want to bring ktlint for the Kotlin code ?
However here will be a bunch of code to re-format it the annotation processor that is already in Kotlin.
There was a problem hiding this comment.
I think ktlint would be great - we would just have to reformat all existing kotlin code to match.
I don't feel like doing it in this PR (since there is already a lot of other kotlin code), but it would be a good thing to do soon.
Thanks for bringing it up, I'll create an issue.
elihart
force-pushed
the
eli-group_recycling
branch
2 times, most recently
from
d92fe45 to
f22f9bc
Compare
|
This has been updated with tests, and a few fixes, plus formatting with ktlint since it was added |
elihart
force-pushed
the
eli-group_recycling
branch
from
ea87c27 to
2589b30
Compare
This was referenced Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a limitation in EpoxyModelGroup that groups with the same view type had to contain the same number of models. This made it very inflexible for dynamically changing group size. Additionally, groups couldn't share subviews between each other, so view recycling was not as effective.
This changes groups to recycle child views into a shared pool among all groups - which also enables groups to have dynamic amounts of models.
This also adds kotlin to the project for the first time 🎉
This works in the sample app, but I still need to write quite a few tests for it.
@ngsilverman @gpeal