We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First of all, thx for open this convention!
LINK : https://github.com/ParkSB/javascript-style-guide#whitespace--chains Here is the examples of convention 19.6 and I have no idea of how the final good example is an improvement of bad one.
good
bad
What does it mean? Why some chainings were cut off?
// bad const leds = stage.selectAll('.led').data(data).enter().append('svg:svg').classed('led', true) .attr('width', (radius + margin) * 2).append('svg:g') .attr('transform', `translate(${radius + margin},${radius + margin})`) .call(tron.led); // good const leds = stage.selectAll('.led') .data(data) .enter().append('svg:svg') .classed('led', true) .attr('width', (radius + margin) * 2) .append('svg:g') .attr('transform', `translate(${radius + margin},${radius + margin})`) .call(tron.led); // good const leds = stage.selectAll('.led').data(data); //<- what does it mean?
The text was updated successfully, but these errors were encountered:
yes, you're right - it's probably supposed to be:
// good const leds = stage.selectAll('.led').data(data); const svg = leds.enter().append('svg:svg'); svg.classed('led', true).attr(width', (radius + margin) * 2); const g = svg.append('svg:g'); g.attr('transform', `translate(${radius + margin},${radius + margin})`).call(tron.led);
(added in #730)
Sorry, something went wrong.
Fixed 19.6 bad example(cut in the middle)
fc6d705
fixed [issue#2403](airbnb#2403)
711aeb6
[editorial] Complete 19.6 example code (cut in the middle)
d150ebb
Fixes airbnb#2403
Successfully merging a pull request may close this issue.
First of all, thx for open this convention!
LINK : https://github.com/ParkSB/javascript-style-guide#whitespace--chains
Here is the examples of convention 19.6 and I have no idea of how the final
good
example is an improvement ofbad
one.What does it mean?
Why some chainings were cut off?
The text was updated successfully, but these errors were encountered: